Change units from KHz to MHz - #29
Merged
Merged
Conversation
Divide cycle throughput values by an additional 1000 so the displayed unit is MHz (millions of cycles per second) instead of KHz (thousands of cycles per second). This aligns with the magnitude typically used when discussing prover performance. - prove_stark: divide by 1_000_000.0 instead of 1000.0 - BenchResult: rename exec_khz/prove_khz to exec_mhz/prove_mhz - BenchSummary: rename all *_khz fields to *_mhz - Update tabled column headers from KHz to MHz Closes #28
zeroklaw
marked this pull request as ready for review
May 13, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Summary
Switch the benchmark output unit from KHz to MHz for all cycle-based throughput measurements. This aligns with the magnitude typically used when discussing prover performance.
Changes
prove_stark: Divide by1_000_000.0instead of1000.0to produce MHz values. The variable name is updated fromkhztomhz.BenchResult: Renameexec_khz→exec_mhz,prove_khz→prove_mhz. Updatetabledcolumn headers to"Exec MHz"and"Prove MHz".BenchSummary: Rename all*_khzfields to*_mhz. Update column headers accordingly.prove_snarkcomment: UpdatedKHz→MHzin the PostgreSQL comment.Testing
cargo build --release -p bento-bench— passesRISC0_SKIP_BUILD=1 cargo clippy -p bento-bench— no new warningsRISC0_SKIP_BUILD=1 cargo test -p bento-bench— 3/3 tests pass